Micron Document
🎖️GitЯра🎖️

Node / meshtastic / Meshtastic-Android / commits / 5a69ac1

Commit 5a69ac101e0eeac8c038bdd60e08bef0b03f2e33

󰉖 Browse tree at this commit

Parents : 8ea6e43
Author : James Rich <2199651+jamesarich@users.noreply.github.com>
Signature : Signature validation error
Date : 2026-08-12T05:07:43-07:00
Committer : GitHub <noreply@github.com>
Date : 2026-08-12T12:07:43Z

chore: remove orphaned SatelliteCountInfo composable (#6633)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Changes

7 files changed, 0 insertions(+), 105 deletions(-)

M core/ui/detekt-baseline.xml -2
D core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/SatelliteCountInfo.kt -51
M feature/node/detekt-baseline.xml -1
D feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/SatelliteCountInfo.kt -43
M screenshot-tests/src/screenshotTest/kotlin/org/meshtastic/screenshots/core/ComponentScreenshotTests.kt -8
D screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Dark_d19fbf1f_0.png
D screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Light_b29dc7a7_0.png

Diff

diff --git a/core/ui/detekt-baseline.xml b/core/ui/detekt-baseline.xml
index d588fb49dc..d4b850442d 100644
--- a/core/ui/detekt-baseline.xml
+++ b/core/ui/detekt-baseline.xml
@@ -13,7 +13,6 @@
<ID>ComposableParamOrder:MaterialBatteryInfo.kt:@Suppress("MagicNumber", "LongMethod") @Composable fun MaterialBatteryInfo</ID>
<ID>ComposableParamOrder:NodeChip.kt:@Composable fun NodeChip</ID>
<ID>ComposableParamOrder:NodeKeyStatusIcon.kt:@Composable fun NodeKeyStatusIcon</ID>
- <ID>ComposableParamOrder:SatelliteCountInfo.kt:@Composable fun SatelliteCountInfo</ID>
<ID>ComposableParamOrder:SignalInfo.kt:@Composable fun SignalInfo</ID>
<ID>ComposableParamOrder:SwitchPreference.kt:@Composable fun SwitchPreference</ID>
<ID>CompositionLocalAllowlist:LocalAnalyticsIntroProvider.kt:val LocalAnalyticsIntroProvider = compositionLocalOf&lt;@Composable () -> Unit> { {} }</ID>
@@ -119,7 +118,6 @@
<ID>PreviewPublic:PositionPrecisionPreference.kt:@Preview(showBackground = true) @Composable fun PositionPrecisionPreferencePreview</ID>
<ID>PreviewPublic:PreferenceCategory.kt:@Preview(showBackground = true) @Composable fun PreferenceCategoryPreview</ID>
<ID>PreviewPublic:RegularPreference.kt:@Preview(showBackground = true) @Composable fun RegularPreferencePreview</ID>
- <ID>PreviewPublic:SatelliteCountInfo.kt:@PreviewLightDark @Composable fun SatelliteCountInfoPreview</ID>
<ID>PreviewPublic:SecurityIcon.kt:@Preview(name = "All Security Icons with Dialog") @Composable fun PreviewAllSecurityIconsWithDialog</ID>
<ID>PreviewPublic:SignalInfo.kt:@Composable @Preview(showBackground = true) fun SignalInfoSimplePreview</ID>
<ID>PreviewPublic:SignalInfo.kt:@PreviewLightDark @Composable fun SignalInfoPreview</ID>

diff --git a/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/SatelliteCountInfo.kt b/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/SatelliteCountInfo.kt
deleted file mode 100644
index ca9f90c4b7..0000000000
--- a/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/SatelliteCountInfo.kt
+++ /dev/null
@@ -1,51 +0,0 @@
-/*
- * Copyright (c) 2026 Meshtastic LLC
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <https://www.gnu.org/licenses/>.
- */
-package org.meshtastic.core.ui.component
-
-import androidx.compose.material3.MaterialTheme
-import androidx.compose.runtime.Composable
-import androidx.compose.ui.Modifier
-import androidx.compose.ui.graphics.Color
-import androidx.compose.ui.tooling.preview.PreviewLightDark
-import org.jetbrains.compose.resources.stringResource
-import org.meshtastic.core.resources.Res
-import org.meshtastic.core.resources.sats
-import org.meshtastic.core.ui.icon.MeshtasticIcons
-import org.meshtastic.core.ui.icon.Satellites
-import org.meshtastic.core.ui.theme.AppTheme
-
-@Composable
-fun SatelliteCountInfo(
- modifier: Modifier = Modifier,
- satCount: Int,
- contentColor: Color = MaterialTheme.colorScheme.onSurface,
-) {
- IconInfo(
- modifier = modifier,
- icon = MeshtasticIcons.Satellites,
- contentDescription = stringResource(Res.string.sats),
- label = stringResource(Res.string.sats),
- text = "$satCount",
- contentColor = contentColor,
- )
-}
-
-@PreviewLightDark
-@Composable
-fun SatelliteCountInfoPreview() {
- AppTheme { SatelliteCountInfo(satCount = 5) }
-}

diff --git a/feature/node/detekt-baseline.xml b/feature/node/detekt-baseline.xml
index fe8ce9410f..36f977aafa 100644
--- a/feature/node/detekt-baseline.xml
+++ b/feature/node/detekt-baseline.xml
@@ -15,7 +15,6 @@
<ID>ComposableParamOrder:NodeItem.kt:@Composable @Suppress("LongMethod") fun NodeItem</ID>
<ID>ComposableParamOrder:PaxMetrics.kt:@Suppress("LongMethod") @Composable private fun PaxMetricsChart</ID>
<ID>ComposableParamOrder:PowerMetrics.kt:@Suppress("LongMethod") @Composable private fun PowerMetricsChart</ID>
- <ID>ComposableParamOrder:SatelliteCountInfo.kt:@Composable fun SatelliteCountInfo</ID>
<ID>ComposableParamOrder:SignalMetrics.kt:@Suppress("LongMethod", "CyclomaticComplexMethod") @Composable private fun SignalMetricsChart</ID>
<ID>ComposableParamOrder:TracerouteChart.kt:@Suppress("LongMethod", "CyclomaticComplexMethod") @Composable internal fun TracerouteMetricsChart</ID>
<ID>ComposableParamOrder:TracerouteLog.kt:@OptIn(ExperimentalFoundationApi::class) @Suppress("LongMethod", "CyclomaticComplexMethod", "UnusedParameter") @Composable fun TracerouteLogScreen</ID>

diff --git a/feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/SatelliteCountInfo.kt b/feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/SatelliteCountInfo.kt
deleted file mode 100644
index 63f697387f..0000000000
--- a/feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/SatelliteCountInfo.kt
+++ /dev/null
@@ -1,43 +0,0 @@
-/*
- * Copyright (c) 2026 Meshtastic LLC
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <https://www.gnu.org/licenses/>.
- */
-package org.meshtastic.feature.node.component
-
-import androidx.compose.material3.MaterialTheme
-import androidx.compose.runtime.Composable
-import androidx.compose.ui.Modifier
-import androidx.compose.ui.graphics.Color
-import org.jetbrains.compose.resources.stringResource
-import org.meshtastic.core.resources.Res
-import org.meshtastic.core.resources.sats
-import org.meshtastic.core.ui.icon.MeshtasticIcons
-import org.meshtastic.core.ui.icon.Satellites
-
-@Composable
-fun SatelliteCountInfo(
- modifier: Modifier = Modifier,
- satCount: Int,
- contentColor: Color = MaterialTheme.colorScheme.onSurface,
-) {
- IconInfo(
- modifier = modifier,
- icon = MeshtasticIcons.Satellites,
- contentDescription = stringResource(Res.string.sats),
- label = stringResource(Res.string.sats),
- text = "$satCount",
- contentColor = contentColor,
- )
-}

diff --git a/screenshot-tests/src/screenshotTest/kotlin/org/meshtastic/screenshots/core/ComponentScreenshotTests.kt b/screenshot-tests/src/screenshotTest/kotlin/org/meshtastic/screenshots/core/ComponentScreenshotTests.kt
index c75102722e..ecd37f996c 100644
--- a/screenshot-tests/src/screenshotTest/kotlin/org/meshtastic/screenshots/core/ComponentScreenshotTests.kt
+++ b/screenshot-tests/src/screenshotTest/kotlin/org/meshtastic/screenshots/core/ComponentScreenshotTests.kt
@@ -31,7 +31,6 @@ import org.meshtastic.core.ui.component.ListItemDisabledPreview
import org.meshtastic.core.ui.component.ListItemPreview
import org.meshtastic.core.ui.component.MaterialBatteryInfo
import org.meshtastic.core.ui.component.MaterialBluetoothSignalInfo
-import org.meshtastic.core.ui.component.SatelliteCountInfoPreview
import org.meshtastic.core.ui.component.SignalInfo
import org.meshtastic.core.ui.component.SwitchListItemPreview
import org.meshtastic.core.ui.component.TitledCardPreview
@@ -122,13 +121,6 @@ fun ScreenshotChannelInfo() {
ChannelInfoPreview()
}
-@PreviewTest
-@PreviewLightDark
-@Composable
-fun ScreenshotSatelliteCountInfo() {
- SatelliteCountInfoPreview()
-}
-
@PreviewTest
@PreviewLightDark
@Composable

diff --git a/screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Dark_d19fbf1f_0.png b/screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Dark_d19fbf1f_0.png
deleted file mode 100644
index 2d5e13eac9..0000000000
Binary files a/screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Dark_d19fbf1f_0.png and /dev/null differ

diff --git a/screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Light_b29dc7a7_0.png b/screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Light_b29dc7a7_0.png
deleted file mode 100644
index 9716a4bbbf..0000000000
Binary files a/screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/core/ComponentScreenshotTestsKt/ScreenshotSatelliteCountInfo_Light_b29dc7a7_0.png and /dev/null differ

Served by rngit 1.5.2 - Generated in 0.22s